pixelnest / presskit.html

Re-implementation of presskit() as a static site generator
http://pixelnest.io/2017/03/presskit-html/
MIT License
306 stars 51 forks source link

Mobile view improvement #4

Closed djkunedo closed 6 years ago

djkunedo commented 6 years ago

Hi guys. First of all, thanks for presskit.html. It's a great tool, but I think that it could be even better if you could make some improvements on the mobile view. Have you planned to release an update with a responsive and fixed top navigation bar or at least trying to locate the header above or inside the nav tag?

solarsailer commented 6 years ago

Hello,

It's already responsive. A fixed navigation bar would be weird and take too much space, imo. 🤔

Do you have a quick mockup of what you imagine?

Thanks. :)

djkunedo commented 6 years ago

Hi solarsailer,

Yeah it's already responsive, what I meant it's that you could add the navbar so it appears only on mobile resolutions but we would keep using the original look for desktop devices.

I'll try to give you further details about what I have in mind. This is how it currently looks on mobile: currentview I think that the header imager could look better above Pixelnest Studio or below pixelnest.io, imo.

The navbar I have in mind it would be something like this: https://themeisle.com/demo/?theme=Zerif%20Lite (you have to select the mobile view on the top of the web to see the navbar with the hamburger menu buttom). I don't think that this navbar takes too much space, but you could comment the code to fix the navbar and let the users decide to fix it or not if you don't want to fix it by default. If you finally implement the navbar, I guess that the header image would look good below the navbar.

Thanks to you ;)

solarsailer commented 6 years ago

Thanks for the detail.

That's what I thought. We tried to stay true to the original presskit(), but I think it might be better this way, indeed.

I'll look into that if I have some time before the week-end. ;)

Cheers.

solarsailer commented 6 years ago

Hello,

I finally added a way to have an hamburger menu (along other features): https://github.com/pixelnest/presskit.html/releases/tag/0.7.0

Run with presskit build -M and it should be good. ;)

(Don't forget the flag, the hamburger behavior is opt-in, not by default)

Cheers!