search

pixelogik / NearPy

Python framework for fast (approximated) nearest neighbour search in large, high-dimensional data sets using different locality-sensitive hashes.
MIT License
759 stars 152 forks source link

Please fix the Redis store_many_vectors_case #75

Open pixelogik opened 6 years ago

pixelogik commented 6 years ago

@xieqihui Sorry for the hassle.

Could you please create a new pull request for your _store_manyvectors addition and make this little adjustment I suggested, so that _store_manyvectors works even if not Redis is used for storage?

xieqihui commented 6 years ago

I have fixed this according to your suggestion in https://github.com/pixelogik/NearPy/pull/76. Can you check it again?

pixelogik commented 6 years ago

@xieqihui Thanks! Could you do me one more favor and add tests for the new method _store_manyvectors ? Sorry for not mentioning this before, but now that more people are working on NearPy we should take care of the tests for real.

xieqihui commented 6 years ago

I’m working on the tests.

Best regards, Qihui

From: Ole notifications@github.com Reply-To: pixelogik/NearPy reply@reply.github.com Date: Wednesday, 7 February 2018 at 10:42 PM To: pixelogik/NearPy NearPy@noreply.github.com Cc: Qihui Xie qihui@propertyguru.com.sg, Mention mention@noreply.github.com Subject: Re: [pixelogik/NearPy] Please fix the Redis store_many_vectors_case (#75)

@xieqihuihttps://github.com/xieqihui Thanks! Could you do me one more favor and add tests for the new method store_many_vectors? Sorry for not mentioning this before, but now that more people are working on NearPy we should take care of the tests for real.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/pixelogik/NearPy/issues/75#issuecomment-363789671, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AUGNID_Y6rvxCDWZOkxaZtW0igNct0BPks5tSbZVgaJpZM4R7J9-.