search

pixelogik / NearPy

Python framework for fast (approximated) nearest neighbour search in large, high-dimensional data sets using different locality-sensitive hashes.
MIT License
759 stars 152 forks source link

redis object not used in the _add_vector function #88

Open sarthakTUM opened 4 years ago

sarthakTUM commented 4 years ago

Minor issue.

The redis_object in the _add_vector function of the storage_redis.py is not being used since the redis_object is already associated with self, and it should not be passed as an argument to the function.

amorgun commented 4 years ago

Thanks for notising this. redis_object should be used here instead of self.redis_object. This argument is necessary for store_many_vectors method.

sarthakTUM commented 4 years ago

I'll revise the PR

sarthakTUM commented 4 years ago

Thanks for notising this. redis_object should be used here instead of self.redis_object. This argument is necessary for store_many_vectors method.

Done

sarthakTUM commented 4 years ago

@amorgun Could you please check the PR? - I am not able to add you as a reviewer there. Thanks!