search

pixelspark / rethink-swift

A RethinkDB client driver for Swift
https://pixelspark.nl/2015/rethink-swift-a-swift-driver-for-rethinkdb
76 stars 11 forks source link

add support for orderBy, without #3

Closed breathe closed 8 years ago

breathe commented 8 years ago

Hi -- thanks for this library! I'm just getting started with rethink and hoping to use it in a swift project.

I added support for a few new queries -- orderBy, without, getAll with array argument. I'm probably going to need to add pluck as well.

I'm on the last 2.2 commit -- I'm not sure if you'd welcome a pull request that adds these to the 2.2 branch?

pixelspark commented 8 years ago

@breathe sure! I have added a swift-2.2 branch which you can submit your pull requests against. I might even try to port your patches to the swift-3 version afterwards :)

breathe commented 8 years ago

@pixelspark -- Awesome thanks! I've just submitted a pull request against the 2.2 branch. #4

Hopefully I'm doing things a reasonable way -- I'm super new to rethink but your code has been awesome to speed up the learning process!

pixelspark commented 8 years ago

https://github.com/pixelspark/rethink-swift/pull/4 is merged, and I committed similar changes for Swift 3! Thanks & closing.

breathe commented 8 years ago

Awesome! Thanks!!