search

pixeltris / TwitchAdSolutions

7.75k stars 446 forks source link

Already patched the new changes? Still receiving integrity checks #153

Closed Infinitay closed 1 year ago

Infinitay commented 1 year ago

I tested the new VAFT and video-swap-new scripts for uBo not less than an hour ago, and both of the updated scripts were working with no problem. They behaved the same in which during ads, the stream used a lower quality stream as fallback with no issue. Side note, was this intended for them to behave the same? I thought they were different.

An hour later and I'm met with a black screen where no stream is loading. Not even for channels I am subscribed to. I tried looking into console to see if there are any logs (btw could you prefix the console.logs with [TwitchAdSolutions] or something please). Did they once again update their integrity check? I just skimmed thru #150 and saw mentions of the check prior to your changes.

image

I say this because I also just noticed that TTV-LOL-PRO just pushed a change referencing to an integrity check within their code https://github.com/younesaassila/ttv-lol-pro/commit/0d078bf91e302029bc9bf7c4aff94555b20a946b

EDIT: Just turned off uBo and the problem is still happening. Maybe it's not because of the script?

pixeltris commented 1 year ago

Those console errors are currently from normal operation of Twitch.

They are tentatively using the integrity checks which is probably why you saw the loading error. It should be fixed by https://github.com/pixeltris/TwitchAdSolutions/commit/2bfda1e1a1c55d7b2dd4a541242acb5033644237

They behaved the same in which during ads, the stream used a lower quality stream as fallback with no issue. Side note, was this intended for them to behave the same? I thought they were different.

vaft was a fork of one of my old scripts that someone made into an extension which a lot of people used. He injected referral links or something so it got taken down. vaft is aggressive with re-requesting the stream to get a clean stream as quickly as possible. The way it's implemented can easily introduce stuttering / freezing / etc.

video-swap-new was designed in a way which should in theory be more stable in terms of stuttering / freezing at the cost of slightly longer ad breaks in some cases. Unfortunately people still have stability issues.

stevenya97 commented 1 year ago

@pixeltris Side question, in the past video-swap-new was mentioned to work better in browsers like Firefox compared to vaft. Is that still the case?

pixeltris commented 1 year ago

I have no idea tbh. I use Twitch pretty casually so I only really see prerolls. The main issues are with midrolls. You'll have to try and see which works best for you.