pixeltris / TwitchAdSolutions

7.75k stars 446 forks source link

Is Stream Cleaner legitimate? #171

Closed misternebula closed 1 year ago

misternebula commented 1 year ago

Link : https://chrome.google.com/webstore/detail/stream-cleaner/lehcglgkjkamolcflammloedahjocbbg

It seems to block ads fine, but some people have said it's a data farming extension? I've looked through all the javascript and nothing seems out of place.

revunix commented 1 year ago

That looks fishy af

EatingCarBatteries commented 1 year ago

I am not going to base this analysis on the source code, because I don't know JS. Instead, the website:

image

pixeltris commented 1 year ago

I wouldn't recommend using it.

Look at the manifest:

https://robwu.nl/crxviewer/?crx=https://chrome.google.com/webstore/detail/stream-cleaner/lehcglgkjkamolcflammloedahjocbbg&qf=manifest.json

Compared to the original:

https://github.com/cleanlock/VideoAdBlockForTwitch/blob/master/chrome/manifest.json

The manifest adds these additional permissions: notifications, tabs, gcm and runs the content.js script on EVERY page "*://*/*".

Then look at these files:

https://robwu.nl/crxviewer/?crx=https://chrome.google.com/webstore/detail/stream-cleaner/lehcglgkjkamolcflammloedahjocbbg&qf=background.js https://robwu.nl/crxviewer/?crx=https://chrome.google.com/webstore/detail/stream-cleaner/lehcglgkjkamolcflammloedahjocbbg&qf=content.js

This requires the user to go to certain websites made by them or more likely a website with an ad made by them or their partners which will trigger their notification code. This is used to target people who are not familiar to trick them into some type of action. On operating systems such as Windows this looks quite official with the notifications popping up as system notifications. It isn't clear what type of notifications are sent as this needs to be paired with additional web page scripts.

Does the Twitch ad blocking work? Yes. It uses the VAFT script:

https://robwu.nl/crxviewer/?crx=https://chrome.google.com/webstore/detail/stream-cleaner/lehcglgkjkamolcflammloedahjocbbg&qf=ads.js

Google should do a better job of auditing their extensions.

ghost commented 11 months ago

Stream Cleaner does work better than recommended ttv lol pro though and is free. I haven't had any buffering issues with stream cleaner, Whereas in ttv lol pro there are limited amount of proxies so at some point either it will buffer or slip an ad due to the limit in free version (you can find issues about that on internet or extension comments section), surely you can increase number of proxies by donating to the author to get access to more proxies if you like.

Stream Cleaner also shows blocking ads... status in top left corner of video player when ads show up and it starts blocking. I wouldn't mind using in a new profile, if you are concerned about the permission it requires i would recommend creating a new browser profile.

image