pixeltris / TwitchAdSolutions

7.75k stars 446 forks source link

Vaft and video-swap-new pausing after midrolls #187

Closed Medivha closed 3 months ago

Medivha commented 1 year ago

Vaft and Video-Swap-new userscript on tampermonkey with firefox 117.0.1 (addons:frankerfacez + ublock origin) works fine on the first midroll, but on the second it gets stuck on a loading screen. And you have to wait till ads are gone and it automatic refreshes or manually press pause->play and you see the blocking ads on top and refreshes automatic after wards but next midroll it gets stuck again. this is buggy for a long time now i i'm just sick of ttv lol pro(because doesn't work 70% of time) and same for other proxy solutions, so i got back to this. just a automatic pause play would be nice?! or find another fix ;)

pixeltris commented 1 year ago

I watch Twitch very casually and rarely see midrolls so I can't really look into this. But you could try to play around the code that triggers when an ad finishes:

https://github.com/pixeltris/TwitchAdSolutions/blob/e8ff2b03a579532b36adc4319cde043cecc0d0c8/video-swap-new/video-swap-new.user.js#L167-L170

Which results in this being called:

https://github.com/pixeltris/TwitchAdSolutions/blob/e8ff2b03a579532b36adc4319cde043cecc0d0c8/video-swap-new/video-swap-new.user.js#L498

I think vaft does the same but it already does a pause/resume rather than a player reload:

https://github.com/pixeltris/TwitchAdSolutions/blob/e8ff2b03a579532b36adc4319cde043cecc0d0c8/vaft/vaft.user.js#L568-L570

pixeltris commented 1 year ago

Also probably a duplicate of #175

Medivha commented 1 year ago

im testing right now without FrankerFaceZ and got first ad so still waiting for second. but it interesting that without FFZ it runs on low res while the ad runs but with FFZ it runs on source res when the ad runs

Medivha commented 1 year ago

finally second ad and it is working so it is something with FFZ.

this was tested with swap new

edit: so changing from autoplay to embed works with the resolution. now i have to find out how to make it work with FFZ. but later no time right now

Medivha commented 11 months ago

1-2 Days later of my previous post, a lot of People noticed they don't got ads any more. Not related to the script including me so I stopped looking for a solution for now until it breaks again for me(hard to test without getting ads ;) and also i have no clue what i'm doing). germany, firefox, tampermonkey, ublock origin, video swap new script(not VAFT). for my setup. but it depends on location and whatever random setup you have. If you use chrome just don't. You will have it 10 times harder to fight against ads.

good luck finding a solution for you

Medivha commented 11 months ago

Germany is normally super AD heavy. idk what twitch is doing

why would a German browser extension from a german guy living in germany phone "home" to russia???? and i dont even see anything about that in the Privacy policy

EchoDev commented 11 months ago

Potential fix in #199

If someone wants to test it to confirm, this fixed the issue on my end.

pixeltris commented 3 months ago

Consolidating all freezing / pausing / playback issues for vaft into #164

video-swap-new generally shouldn't suffer from the same playback issues but if you're having playback issues see #119