no blocking anymore - Githubissues

stefabaldi commented 4 months ago

when the ads come up the stream start loading and when i try to refresh the page the ad isn't blocked. Other times i see the "blocking mid-roll ads" but the ads aren't blocked at all.

revunix commented 4 months ago

Use TTV LOL PRO

phireblast commented 4 months ago

Use TTV LOL PRO

this still happens with TTV LOL PRO

revunix commented 4 months ago

Use TTV LOL PRO

this still happens with TTV LOL PRO

No, it isn't. I'm using it with a own proxy from https://proxy6.net (china proxy) and it works perfectly since months!

pixeltris commented 4 months ago

I can reproduce this. Under video-swap-new I've observed a few different things:

Ads being displayed
Player load errors
Stream resolution getting stuck at 240p

I think it's mostly midroll issues but may also impact prerolls. I'll look at possible solutions.

Fe-n commented 4 months ago

I can reproduce this. Under video-swap-new I've observed a few different things:
* Ads being displayed

* Player load errors

* Stream resolution getting stuck at 240p
I think it's mostly midroll issues but may also impact prerolls. I'll look at possible solutions.

Thank you. I've also noticed issues with video-swap-new the last few days, but I wasn't sure if it was a transient issue or possibly caused by my sort-of out-of-date BTTV (the Firefox release lags behind the other releases) and hadn't looked into it more yet.

My experience has been:

No pre-roll ads observed when first loading a stream. The low-res embed player seems to be correctly used when they would otherwise play. However, the higher resolution is not swapped to, and unlike at some points in the past, pausing and then unpausing the player does not force a switch. Refreshing the page will either result in ads playing (I think this happened once?) or the stream playing normally at selected resolution.
When mid-roll ads are meant to be played, the stream simply stops playback. Pausing and then un-pausing the player will result in the ads playing.

JTJutajoh commented 4 months ago

In the meantime, I've found that I can fix the "stuck at 240p" part by waiting a few minutes for ads to finish, then using the FFZ "Reset Player" button.

sangohan commented 4 months ago

@Fe-n

However, the higher resolution is not swapped to, and unlike at some points in the past

i had the same issue, but the temporary fix is to click onto another channel, and click back to the original channel. Twitch seems to prevent ads from playing constantly, so there's a timeout/grace period. This means you get back to the high res video (no swaps happening in this circumstance).

I suspect it's just the player on twitch changing and the code not keeping up,

pixeltris commented 4 months ago

Should be fixed by https://github.com/pixeltris/TwitchAdSolutions/commit/9bd481a833341911ac39412dc4abcc41f911af8f

stefabaldi commented 4 months ago

updated today the new version, now the loading neither starts, ads start normally

Matthewkyos commented 4 months ago

even with this patch its still broken

pixeltris commented 4 months ago

Use the userscript version. I updated the readme recently with an additional note about the uBlock Origin script issues:

The scripts may randomly stop being applied by uBlock Origin for unknown reasons (#200). It's recommended to use the userscript versions instead.

Closing this as I imagine most people who use the scripts are up to date.

pseeghosts commented 2 months ago

tried all the url options and none of them held the ads :/

pixeltris / TwitchAdSolutions

no blocking anymore #220