pixeltris / TwitchAdSolutions

7.21k stars 424 forks source link

Vaft userscript on firefox testing #222

Closed izar3 closed 4 months ago

izar3 commented 4 months ago

I am using violetmonkey addon and get varied results with the vaft userscript

Here are some tests I have done changing violetmonkey injection modes, what I hope is useful information:

Synchronous page mode: This setting works the best when a midroll ad starts but desync will occur after midroll ads. instant injection is to soon function findReactNode() and fails to find the videoPlayer, so it does not pause then play after ads what causes sync issues

Alternate page mode for firefox (default for violentmonkey): Video always freezes during ads. The video resolution of the player changes a few times causing it to freeze. Resumes fine after ad is finished

Alt mode and Synchronous mode both off: Infinite Buffer when a midroll ad starts. Manual pause then play fixes it. Resumes fine after ad is finished

solution?: I think if the script uses Synchronous page mode then pause then play after "blocking ads" overlay is removed from the video player this script will run flawless because I saw 2-3 midrolls over a few hours and I manually paused then played after each ad to fix the desync and it worked without issues

ty

pixeltris commented 4 months ago

findReactNode() and fails to find the videoPlayer

This is due to #220 and should be fixed in https://github.com/pixeltris/TwitchAdSolutions/commit/9bd481a833341911ac39412dc4abcc41f911af8f

I'm not sure if the freezing issues are also related or not. There have been other freezing related issues for a while though so I'm going to close this in favor of the already open issues #119 / #164