search

pixeltris / TwitchAdSolutions

7.21k stars 424 forks source link

Please exclude VODS from the ublock origin script. #251

Open chrcoluk opened 1 month ago

chrcoluk commented 1 month ago

When watching VODs on twitch the script causes the page to hang in firefox, I have to forcefully kill the tab.

I have attempted to try and alter the ublock rule, but I dont know ad block syntax and was told on reddit its not possible, but instead to come here and ask for the script to be changed to not process on VODS.

VODs load from the /videos/ url.

pixeltris commented 2 weeks ago

I can't reproduce this issue under firefox. Looking at the code and comparing it to the m3u8 requests I don't see anything that would negatively impact /videos/ urls. Closing for now. An example VOD url where this occurs would be useful.

chrcoluk commented 2 weeks ago

I think it gets triggered when audio is mooted due to copyright and it mistakes it as an advert.

Essentially when the issue happens I see in the corner it is blocking ad's but VOD's dont have ad's so exempting even if you cant reproduce it shouldnt be a problem.

pixeltris commented 2 weeks ago

Essentially when the issue happens I see in the corner it is blocking ad's but VOD's dont have ad

I think that happens when you're on a stream and an ad plays then you click through to vods. The url changes but the page is still the same so even if /videos/ was filtered out the script would stay loaded. But I'll take a look and see if the script is doing anything crazy in that scenario.