pixeltris / TwitchAdSolutions

7.21k stars 424 forks source link

Does not work anymore ?. #252

Closed Geant200 closed 2 weeks ago

Geant200 commented 1 month ago

Good morning

I am creating the post to warn you that your script no longer works, the ads are visible again and are no longer blocked.

An update is necessary I think?

I thank you in advance.

evilmaran commented 1 month ago

same issues, no clue what to do atm. Tried everything i could find with ddg/google

filipemanuelofs commented 1 month ago

Same.. I was getting ads with vaft. I changed to video-swap-new and it stopped.

revunix commented 1 month ago

I seriously wonder how many more topics will be opened here on this subject. We know by now that this script no longer works properly...

CoffeNook commented 1 month ago

It stopped working for me today

stevenya97 commented 1 month ago

Lets get some extra info again, what browser are you guys and what extensions are you using? Do you see any references to ads in your browser console?(hit F12 and filter console output to "ads"). If not, the scripts are potentially NOT loading correctly.

Screenshot 2024-05-30 200317

image

If you have any chat related extensions/addons, like FFZ or BetterTTV, they shouldn't conflict with the scripts here but you can try disabling those. If you have other twitch ad-block solutions like TTV LOL Pro that are proxy based, try disabling that and using only the vaft or video-swap-new scripts. Double check the userResourceLocation URL is set correctly if you are using uBlock Origin to apply the scripts. uBo has some known issues(#200) with the scripts so try the userscript versions instead. Be sure to clear your uBo setup by removing the filter and making the url unset Screenshot 2024-05-30 201752

Geant200 commented 1 month ago

For my part it's good, it's back to normal, thank you for the changes.

evilmaran commented 1 month ago

Lets get some extra info again, what browser are you guys and what extensions are you using? Do you see any references to ads in your browser console?(hit F12 and filter console output to "ads"). If not, the scripts are potentially NOT loading correctly.

Screenshot 2024-05-30 200317

image

If you have any chat related extensions/addons, like FFZ or BetterTTV, they shouldn't conflict with the scripts here but you can try disabling those. If you have other twitch ad-block solutions like TTV LOL Pro that are proxy based, try disabling that and using only the vaft or video-swap-new scripts. Double check the userResourceLocation URL is set correctly if you are using uBlock Origin to apply the scripts. uBo has some known issues(#200) with the scripts so try the userscript versions instead. Be sure to clear your uBo setup by removing the filter and making the url unset Screenshot 2024-05-30 201752

Most issues have been resolved, sometimes loading/buffering seems to take longer, also would like some clarification on if other extensions (like FFZ, 7TV, alternate player) interfere with the scripts, should i be running only vaft or can i run both vaft and video-swap-new?

When i pull up console i do see some ads references like: <link href="data:text/css,%3Ais(%5Bid*%3D'google_ads_iframe'%5D%2C%5Bid*%3D'taboola-'%5D%2C.taboolaHeight%2C.taboola-placeholder%2C%23credential_picker_container%2C%23credentials-picker-container%2C%23credential_picker_iframe%2C%5Bid*%3D'google-one-tap-iframe'%5D%2C%23google-one-tap-popup-container%2C.google-one-tap-modal-div%2C%23amp_floatingAdDiv%2C%23ez-content-blocker-container)%20%7Bdisplay%3Anone!important%3Bmin-height%3A0!important%3Bheight%3A0!important%3B%7D" rel="stylesheet" type="text/css">

Using Firefox and some other twitch extensions like 7TV and FFZ, also use "Alternate Player for Twitch" sometimes but only when Twitch get super annoying with ads and even then Alternate Player doesnt always get rid of ads anymore. Vaft and video-swap-new scripts are loaded with Greasemonkey. And ofcourse Ublock Origin is always running, with some added filters for YouTube.

edit just double checked, i also had TTV LOL PRO, just disabled that, so ill check back here if that didnt do anything.

stevenya97 commented 1 month ago

@evilmaran twitch player/chat extensions should be fine. I'm running FFZ and no issues. You should have only one ad block solution active, so either vaft or video-swap-new active not both. They both monitor the m3u8 video stream so they can conflict with each other. You can keep both in greasemonkey just have only one active. You can swap between them if having issues. This extends to other extensions as well that offer ad block capabilities. For example Adguard Extra includes Twitch adblocking that is similar to vaft, if you use that I'd exclude twitch.tv from it

evilmaran commented 1 month ago

@evilmaran twitch player/chat extensions should be fine. I'm running FFZ and no issues. You should have only one ad block solution active, so either vaft or video-swap-new active not both. They both monitor the m3u8 video stream so they can conflict with each other. You can keep both in greasemonkey just have only one active. You can swap between them if having issues. This extends to other extensions as well that offer ad block capabilities. For example Adguard Extra includes Twitch adblocking that is similar to vaft, if you use that I'd exclude twitch.tv from it


Gave it a few days, but seems with both scripts i do get ads, alternating between the 2 when an ad shows up to see which one works better, seems neither blocks ads atm for me.

stevenya97 commented 1 month ago

Are you seeing the banner Blocking ads or Blocking midroll ads in the top left of the player when ads happen? The video quality should be dropping to 360p-ish during the ad. image

Copying over my suggestions from #257 facing similar issues. Let's filter out only Logs in your console and check for ads entries again. If you don't see those messages, the script is not being loaded/detecting ads for you for some strange reason.

Let's also check if the script is detecting any ads. If you open the Firefox dev tools(F12), tab over to Console, next to filter output make sure Logs are highlighted and shown. You should be able to view any stream and if the script finds an ad it should print Found ads, switch to backup in the console. There will also be an associated message when the ad is over and the player switches back to the full quality stream. If there are too many messages to scroll through, you can use the Filter Output search bar to just narrow it to ads. These messages are built into the script itself so it tells us if things are working right. I just tested with a random stream and this behavior does work on my end. Should apply to both prerolls and midrolls. If you do not see these messages, then the script is not being loaded.

Screenshot 2024-06-03 at 1 25 16 AM

evilmaran commented 1 month ago

think i found the problem, while running vaft: Source map error: Error: URL constructor: is not a valid URL. Resource URL: user-script:https%3A//github.com/pixeltris/TwitchAdSolutions/TwitchAdSolutions%20%28vaft%29 Source Map URL: null

i double checked my settings in ublock that it is using all the correct links etc, refreshed twitch and:

Script error in [Greasemonkey script https://github.com/pixeltris/TwitchAdSolutions/TwitchAdSolutions (vaft); version 8.0.0]: TypeError: "fetch" is read-only TwitchAdSolutions (vaft):885:19 Source map error: Error: URL constructor: is not a valid URL. Resource URL: user-script:https%3A//github.com/pixeltris/TwitchAdSolutions/TwitchAdSolutions%20%28vaft%29 Source Map URL: null

swapped to video-swap-new script and:

Script error in [Greasemonkey script https://github.com/pixeltris/TwitchAdSolutions/TwitchAdSolutions (video-swap-new); version 1.24]: TypeError: "fetch" is read-only TwitchAdSolutions (video-swap-new):695:19 Source map error: Error: URL constructor: is not a valid URL. Resource URL: user-script:https%3A//github.com/pixeltris/TwitchAdSolutions/TwitchAdSolutions%20%28video-swap-new%29 Source Map URL: null

what does this mean exactly? which url should be changed?

update:

after a few mins of watching a stream with console open i saw this message come by:

Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://edge.ads.twitch.tv/ads?cid=32250813&dur=15&geoc=NL&did=0hlETYn3WB8ucfwEDxFVOS6tUA7X1pv7&dt=2&pid=4975889155731717492012227&cb=5679106&ws=1920x417&u=https%3A%2F%2Fwww.twitch.tv%2Fsummit1g&pj=%7B%22game%22%3A%22dayz%22%2C%22chan%22%3A%22summit1g%22%2C%22chanid%22%3A%2226490481%22%2C%22twitchcorrelator%22%3A%22df235cb74f0d4a169246cb165985a2fa%22%2C%22embed%22%3A%22false%22%2C%22platform%22%3A%22web%22%2C%22mature%22%3A%22false%22%2C%22pos%22%3A%222%22%2C%22timebreak%22%3A%2260%22%2C%22tag%22%3A%22fps%7Cshooter%7Crpg%7Csimulation%7Cadventure_game%22%2C%22content_labels%22%3A%22%22%2C%22chantype%22%3A%22partner%22%2C%22delivery_type%22%3A%22csai%22%2C%22vb%22%3A%22null%22%2C%22adunit%22%3A%22web_csai%22%2C%22loggedin%22%3A%22true%22%2C%22v%22%3A%22undefined%22%2C%22vod_type%22%3A%22live%22%2C%22embed_url%22%3A%22null%22%2C%22game_id%22%3A%2265632%22%7D&gdprl=%7B%22status%22%3A%22cmp%22%7D&pbid=twitch&bp=midroll&aid=0hlETYn3WB8ucfwEDxFVOS6tUA7X1pv7&cat=DayZ&catid=65632&chanid=26490481&chan=summit1g&chantype=partner&commid=84cffb730f364c09a7d0da6d1c32dcc5&mafs=CggKAggEEgIIAw%3D%3D&plat=web&rtok=eyJhbGciOiJIUzUxMiIsInR5cCI6IkpXVCJ9.eyJicm9hZGNhc3RlciI6IjI2NDkwNDgxIiwidmlld2VyIjoiMzIyNTA4MTMiLCJzZXNzaW9uIjoiZGYyMzVjYjc0ZjBkNGExNjkyNDZjYjE2NTk4NWEyZmEiLCJ2aWRlb19zZXNzaW9uX2lkIjoiNzc2NDExODcwMjM5NjQ0NTg2NCIsInBsYXRmb3JtX3R5cGUiOiJXRUIiLCJkdXJhdGlvbiI6MzAsImlzX3ZsbSI6dHJ1ZSwiaXNfc3RpdGNoZWQiOmZhbHNlLCJpYXQiOjE3MTc0OTIwMDUsImlzcyI6IkdyYW5kREFkcyJ9.DHl8pTnJ2OARSXeI8iltArV2TG2WtmGtnvO_oelVGurg-PsZoRf-ynPFmxE1v_FRT7vN_7ypes1_ZBxnHvARFg&sid=df235cb74f0d4a169246cb165985a2fa&tags=fps%7Cshooter%7Crpg%7Csimulation%7Cadventure_game&mseq=4&sdaseq=1&tcor=df235cb74f0d4a169246cb165985a2fa&uid=32250813&vtype=live. (Reason: CORS request did not succeed). Status code: (null).

update: currently getting the little "blocking midroll ads"banner with 360p stream resolution...

xunkar commented 1 month ago

I'm using Firefox and video-swap-new via uBlock Origin, no other browser extension beside FFZ, and when ads are playing there are 0 messages in the console mentioning ads, things were working fine until recently. I've tried clearing cache to no avail.

stevenya97 commented 1 month ago

@evilmaran I see in your edit that you are getting the banner now? Does this mean it works now? The 360p stream is intended behavior. The script stitches the live stream preview(only stream currently that doesn't have ads embedded in them) that twitch sometimes places above chat during ads with the clean audio feed together. It should jump back to full quality after the ad is over.

evilmaran commented 1 month ago

yes it seems to be working, still have those errors in console logs...

now to figure out what happened with youtube and reddit....

stevenya97 commented 1 month ago

@xunkar Under the My filters tab in the uBlock dashboard, did you add twitch.tv##+js(twitch-videoad)? If you are not seeing any messages in the console then the script is not being loaded for some reason. First step would be to double check your config. Perhaps the link to the script needs to be updated on your end?

stevenya97 commented 1 month ago

@evilmaran It is just a warning label(yellow not critical red) so as long as sites function correctly you can ignore them. I have a couple similar messages related to FrankerFaceZ twitch extension. It might be CORS or Enhanced Tracking Protection related depending on how you have your Firefox setup.

Youtube and Reddit are outside the scope of this thread but you can ask on r/uBlockOrigin or r/Firefox if you want other opinions. You can also research CORS for details on how to configure it but most likely those domains are throwing a warning for security/anti-tracking purposes by Firefox. That last edge.ads.twitch.tv message indicates that the page ad was blocked.

xunkar commented 1 month ago

@xunkar Under the My filters tab in the uBlock dashboard, did you add twitch.tv##+js(twitch-videoad)? If you are not seeing any messages in the console then the script is not being loaded for some reason. First step would be to double check your config. Perhaps the link to the script needs to be updated on your end?

Yes I have. I've managed to make it work by switching to vaft, not sure why video-swap-new won't load properly though.

pixeltris commented 2 weeks ago

Closing as I can't reproduce. userscript version is always recommended.