pixeltris / TwitchAdSolutions

7.21k stars 424 forks source link

Purple "Commercial Break" screen #257

Closed uruzrune closed 2 weeks ago

uruzrune commented 1 month ago

Any chance of this being resolved in the near future?

stevenya97 commented 1 month ago

What browser are you using? Did you apply the uBlock or Userscript scripts? Do you have any other Twitch related extensions installed?

uruzrune commented 1 month ago

Firefox 126.0.1 (64-bit).

If I use uBlock Origin only with the usual script:

userResourcesLocation https://raw.githubusercontent.com/pixeltris/TwitchAdSolutions/master/video-swap-new/video-swap-new-ublock-origin.js

It doesn't seem to work at all, and I see ads.

If I turn on TTV LOL PRO, I will no longer see ads, but I will occasionally get the purple break screen.

The only other extension I use that's Twitch related is BetterTTV, and I would not expect something that's emote-focused to affect adblocks.

stevenya97 commented 1 month ago

Hmm. Let's double check your uBlock Origin dashboard again. Under the My filters tab, check/add twitch.tv##+js(twitch-videoad). You are correct chat related extensions shouldn't affect it. Proxies like TTV LOL PRO should just override it but we can ignore that for now since it's not working with it off anyway.

Let's also check if the script is detecting any ads. If you open the Firefox dev tools(F12), tab over to Console, next to filter output make sure Logs are highlighted and shown. You should be able to view any stream and if the script finds an ad it should print Found ads, switch to backup in the console. There will also be an associated message when the ad is over and the player switches back to the full quality stream. If there are too many messages to scroll through, you can use the Filter Output search bar to just narrow it to ads. These messages are built into the script itself so it tells us if things are working right. I just tested with a random stream and this behavior does work on my end. Should apply to both prerolls and midrolls. If you do not see these messages, then the script is not being loaded. Screenshot 2024-06-03 at 1 25 16 AM

Zevgor commented 1 month ago

Same issue here. Double checked my filters. It has stopped working.

Elaws commented 4 weeks ago

Same issue here - Firefox - Windows 11 - uBlock origin without any scripts.

I followed the advice on the homepage of TwitchAdSolutions repo to use TTV LOL PRO instead of the scripts.

I very often get these annoying purple screens for 30 seconds.

zGato commented 4 weeks ago

I very often get these annoying purple screens for 30 seconds.

Read wiki, not an extension-wise issue.

Elaws commented 4 weeks ago

TL;DR : I uninstalled TTV LOL PRO and added the vaft script again. Everything seems to be working fine as it used to. Will report if needed.

I very often get these annoying purple screens for 30 seconds.

Read wiki, not an extension-wise issue.

Thank you @zGato. Not sure what you meant, but by complete luck, I happen to have found this repo, in which there was a wiki link that seemed to be related to TTV LOL PRO : https://wiki.cdn-perfprod.com/.

Somewhere in the wiki (in Extension > Troubleshooting > "I get "commercial break in progress" ads), there was a section that seems to describe the problem mentioned in this issue : TL;DR unknown issue, install vaft as workaround / solution.

uruzrune commented 4 weeks ago

@stevenya97 So it doesn't look like the script is being loaded. I've tried it in userResourcesLocation, and I've also tried it under Import on Filter Lists (although I didn't expect that to work, really)

One thing I noticed is that both the vaft script and the standard TwitchAdSolutions script has this as the first line:

"twitch-videoad.js text/javascript"

From what I understand, that's not valid javascript, and it's possible the scripts are just not executing because of this. Can you confirm that line is acceptable?

What else could be preventing uBlock Origin from running this script?

uruzrune commented 4 weeks ago

@stevenya97 so removing the script from uBlock Origin and running it as a userscript through Tampermonkey worked. I had to disable TTV LOL PRO else I would have a black screen with a spinner.

So something is broken with the script execution and uBlock Origin.

stevenya97 commented 4 weeks ago

So something is broken with the script execution and uBlock Origin.

Yeah it is a known issue with uBo, can see #200 for the discussion. uBo removed the Purge cache button that would force a reload of the script so there currently isn't a great solution besides using the userscript versions.

I had to disable TTV LOL PRO else I would have a black screen with a spinner.

TTV LOL PRO likely conflicts with the script, I would use one or the other for now if you are facing issues.

pixeltris commented 2 weeks ago

Generally you shouldn't get a purple screen with either of the two scripts in this repo. Possibly some geographic locations could cause it but otherwise it's normally caused by the embedded player (though I don't think they use purple screen for it anymore, it's a multi colored thing).