pixeltris / YgoMaster

Offline Yu-Gi-Oh! Master Duel
MIT License
886 stars 127 forks source link

Need clarity on updating.md #351

Closed ArSoulSin closed 8 months ago

ArSoulSin commented 8 months ago

Hello, I made an attempt to update the game myself following the structions on the updating.md file. There are a few segments tough that lack a bit of clarity, and it would be wonderfull for it, the guide, to be updated.

I dunno if I was missing something thats common knowledge on the development, but what didnt made sense was:

Line 17: TitleLoop.json is not being created by that procedure. Missing anything?

Line 31: I do not understand "where" I am supposed to enter the AlwaysWin command.

Line 79 and 80: Pretty much everything on Misc doesn't make much sense. Dumping the updatediff.cs file makes sense. Lacks clarity on where should I "insert" it tough. Also "what" is supposed to update? YgoMaster or Steam client? How do I check the output for Program.cs ? How to "run" it after comment?

And finally a question: I've updated everything except Misc and Solo and still can't see the new update cards on YgoMaster. Is anything in specific missing?

pixeltris commented 8 months ago

Line 17: TitleLoop.json is not being created by that procedure. Missing anything?

This log will only show up when you first open the game. Start logging prior to opening the game.

Line 31: I do not understand "where" I am supposed to enter the AlwaysWin command.

It isn't a command it's a client setting which has a boolean value. It isn't in the settings by default. You need to add it https://github.com/pixeltris/YgoMaster/blob/master/YgoMaster/Data/ClientData/ClientSettings.json

You then inject into the live game https://github.com/pixeltris/YgoMaster/blob/master/Docs/LiveMods.md

Line 79 and 80: Pretty much everything on Misc doesn't make much sense.

You don't have to worry about this stuff unless you want to maintain the YgoMaster codebase. It's information for finding breaking changes to the clients code when Master Duel has client updates https://steamdb.info/depot/1449853/manifests/

And finally a question: I've updated everything except Misc and Solo and still can't see the new update cards on YgoMaster. Is anything in specific missing?

Did the CardList.json and other json files get created? You have to manually copy them over to your YgoMaster's Data folder as mentioned in the instructions.

ArSoulSin commented 8 months ago

Did another atempt today and got it working. Thanks.