pixie-io / pixie

Instant Kubernetes-Native Application Observability
https://px.dev
Apache License 2.0
5.52k stars 427 forks source link

Fix dry run logic #1921

Closed ddelnano closed 4 months ago

ddelnano commented 4 months ago

Summary: Fix use of GitHub expression to fix image mirroring dry run logic

The version of the workflow on main always runs with --dry-run provided regardless of the input value. I thought that the 'else' case of a ternary could be omitted, but that was incorrect. The latest implementation aligns with the example in the GitHub docs.

Relevant Issues: Precursor to fixing px-sock-shop (https://github.com/pixie-io/pixie/issues/1905)

Type of change: /kind bug

Test Plan: Updated based on the docs. Needs to be validated with a workflow run against a branch in the pixie-io org