search

pixie-io / pixie

Instant Kubernetes-Native Application Observability
https://px.dev
Apache License 2.0
5.38k stars 416 forks source link

Remove dry_run inputs responsible for regbot dry runs to always execute #1923

Closed ddelnano closed 1 month ago

ddelnano commented 1 month ago

Summary: Remove dry_run inputs responsible for regbot dry runs to always execute

I attempted to fix the bug where --dry-run is always passed to the regbot cli in the mirror workflows in #1921. That attempt unfortunatley did not work, so let's remove the input and the cli argument templating entirely. Running regbot --dry-run locally is an easy enough mechanism for testing the workflow logic.

Relevant Issues: Precursor to fixing px-sock-shop (https://github.com/pixie-io/pixie/issues/1905)

Type of change: /kind bug

Test Plan: Expecting that the next run off main after this change will result in mirrored demo container images