pixie-io / pixie

Instant Kubernetes-Native Application Observability
https://px.dev
Apache License 2.0
5.38k stars 416 forks source link

Fix busybox path in plugin job with switch to `x86_64_sysroot` skaffold profile #1943

Closed ddelnano closed 1 week ago

ddelnano commented 4 weeks ago

Summary: Fix busybox path in plugin job with switch to x86_64_sysroot skaffold profile

1941 switched the cloud skaffold build to use the x86_64_sysroot profile. After that was introduced, the plugin load job no longer runs due to a missing /busybox path. This change updates the kubernetes manifests to work with the correct path.

Relevant Issues: N/A

Type of change: /kind cleanup

Test Plan: Verified the following:

$ sudo docker run --entrypoint sh -it bazel/src/cloud/plugin/load_db:plugin_db_updater_image

ls -alh /busybox

ls: cannot access '/busybox': No such file or directory

- [x] `src/cloud/plugin/load_db:plugin_db_updater_image` does contain `/busybox` without sysroot config (previous behavior in skaffold)

$ bazel run src/cloud/plugin/load_db:plugin_db_updater_image

$ sudo docker run --entrypoint sh -it bazel/src/cloud/plugin/load_db:plugin_db_updater_image /app/src/cloud/plugin/load_db/load_db.runfiles/px # ls -alh /busybox [ ... ]

total 1M drwxr-xr-x 2 root root 12.0K Feb 27 2023 . drwxr-xr-x 1 root root 4.0K Jun 21 17:34 .. lrwxrwxrwx 1 root root 7 Feb 27 2023 [ -> busybox lrwxrwxrwx 1 root root 7 Feb 27 2023 [[ -> busybox lrwxrwxrwx 1 root root 7 Feb 27 2023 acpid -> busybox


- [x] New cloud deploy is successful