Convert `users.profile_picture` column to `TEXT` type

pixie-io / pixie

Instant Kubernetes-Native Application Observability

https://px.dev

Apache License 2.0

5.52k stars 427 forks source link

Convert `users.profile_picture` column to `TEXT` type #1951

Closed ddelnano closed 3 months ago

ddelnano commented 3 months ago

Summary: Convert users.profile_picture column to TEXT type

My Google account's most recent profile picture's URL contains 1032 characters (link here). This is larger than the 1024 VARCHAR for the users.profile_picture columen. This change converts the column to use a TEXT type to avoid issues with long URLs.

Relevant Issues: N/A

Type of change: /kind bug

Test Plan: Recently deployed cloud no longer fails at login

vihangm commented 3 months ago

I think we should consider just migrating it to type TEXT.