pixie-io / pixie

Instant Kubernetes-Native Application Observability
https://px.dev
Apache License 2.0
5.6k stars 430 forks source link

Support plugin service API calls from Go client #566

Open tharinduwijewardane opened 2 years ago

tharinduwijewardane commented 2 years ago

Is your feature request related to a problem? Please describe. Cannot create/update retention scripts programmatically

Describe the solution you'd like Add the support to call plugin service API from Go SDK

Describe alternatives you've considered

Additional context

tharinduwijewardane commented 2 years ago

This can be achieved by adding cloudpb.PluginServiceClient to the VizierClient struct

@aimichelle @zasgar Is this acceptable ?

aimichelle commented 2 years ago

Hi @tharinduwijewardane ! Thanks for the suggestion! Registering plugin scripts is an operation done through the cloud, so it would actually make most sense to add it to the cloud client operations instead, and initialize the client here (see cmClient).

tharinduwijewardane commented 2 years ago

I will send a PR soon