pixie16 / paass

Pixie Acquisition and Analysis Software Suite
https://pixie16.github.io/paassdoc/
GNU General Public License v3.0
10 stars 29 forks source link

Error in GlobalsXmlParser::ParseRejectNode logic #247

Closed spaulaus closed 7 years ago

spaulaus commented 7 years ago

Description

There's a bug in the parsing of the rejection regions. The logic

if ( start == 0 || end == 0 || start > end) {
            ss << "Globals: incomplete or wrong rejection region "
               << "declaration: " << start << ", " << end;
            throw invalid_argument(ss.str());
        }

Should read

if ( (start == 0 && end == 0) || start > end) {
            ss << "Globals: incomplete or wrong rejection region "
               << "declaration: " << start << ", " << end;
            throw invalid_argument(ss.str());
        }

Work to be done

  1. Correct logic so that the rejection regions are read properly when the start is set to 0

Acceptance criteria

  1. Rejection regions with start=0 are read properly.
tking53 commented 7 years ago

This was resolved by #248