search

pixie16 / paass

Pixie Acquisition and Analysis Software Suite
https://pixie16.github.io/paassdoc/
GNU General Public License v3.0
10 stars 29 forks source link

Code does not parse <TrapFilters> node of the xml #249

Closed tking53 closed 7 years ago

tking53 commented 7 years ago

Description

GlobalsXmlParser.cpp is where this is (trys to be) parsed. Part of the issue I think I have fixed, but the second part is unknown to me. The first part of the issue was the missing .empty() in the leading if condition; without it the loop is never entered. The second part is that the values are never parsed. This is from kqxhc, and I'm on my Ornl2016 Branch but I'm even with dev. I rebased yesterday after the Rootfitter pull request (#239).

The parsing code for pixie16/dev is here. This has been updated in my fork, which is here.

The cout for the name is empty, and the attribute values are 0 (or the defaults when the codes running)

Work to be done

  1. The Trapezoidal filter parameters are parsed properly.

Acceptance Criteria

  1. All of the software compiles
  2. The TraceFilterAnalyzer returns the proper values parsed from the node.
spaulaus commented 7 years ago

Please make sure your bug reports conform to the proper style. Do not copy/paste the code from some unknown location and commit. You can link directly to a line from a specific commit. That output should be summarized and the extraneous information removed.

tking53 commented 7 years ago

updated

spaulaus commented 7 years ago

See Issue #199 or #243 for proper formatting. You also didn't remove the extraneous information from the original post.