search

pixie16 / paass

Pixie Acquisition and Analysis Software Suite
https://pixie16.github.io/paassdoc/
GNU General Public License v3.0
10 stars 29 forks source link

Need better error handling for legacy nodes in XML #250

Closed spaulaus closed 7 years ago

spaulaus commented 7 years ago

Description

Many of the utkscan configuration files that are shipped with the software have not been updated to the latest XML scheme. The contain legacy nodes, and other formatting issues that will cause errors when they are used with the software. We should add some error handling to the parsing routines that checks for these legacy nodes and warns the user that they exist. Legacy nodes like the Timing node need to throw an exception when they're encountered because they will really throw a monkey wrench into the parsing of the Trace and Fitting nodes.

Work to be done

  1. Identify all of the legacy nodes that are in the configuration files
  2. Identify the nodes that could cause critical errors.
  3. Create a validation class (method?) that will validate nodes and look for the legacy nodes.
  4. Update the example.xml so that it no longer contains legacy information.

Acceptance Criteria

  1. All software compiles
  2. Old XML files are parsed properly, and all legacy nodes are listed to the user
  3. Old XML files throw errors if the legacy node encountered could cause a critical error.
  4. example.xml throws no errors.
spaulaus commented 7 years ago

I'm updating the wiki as well.