search

pixie16 / paass

Pixie Acquisition and Analysis Software Suite
https://pixie16.github.io/paassdoc/
GNU General Public License v3.0
10 stars 29 forks source link

Resolves Issue 256: Adds a missing ld flag (-ltinfo) #258

Closed tking53 closed 7 years ago

tking53 commented 7 years ago

This was needed on the Bill laptop. I would like Miguel to test this. (I cant find his github username in the list). This doesn't seem to break anything on my laptop (ubuntu 16.10 gsl2.3 gcc 6.2)

ksmith0 commented 7 years ago

This is related to issue #256. I believe it is an issue with the compiler on that machine and should not be added to the cmake scripts as it should be automatically determined.

ksmith0 commented 7 years ago

Maybe something along these lines?

CHECK_LIBRARY_EXISTS("${CURSES_NCURSES_LIBRARY}"
    cbreak "" CURSES_NCURSES_HAS_CBREAK)
  if(NOT CURSES_NCURSES_HAS_CBREAK)
    find_library(CURSES_EXTRA_LIBRARY tinfo)
    list(APPEND CURSES_LIBRARIES CURSES_EXTRA_LIBRARY)
  endif(NOT CURSES_NCURSES_HAS_CBREAK)
tking53 commented 7 years ago

I have implemented something similar to what @ksmith0 suggested. This works on the BILL laptop and correctly finds the needed library. it still compiles on kqxhc and my ubuntu laptop.

tking53 commented 7 years ago

i have run into a weird issue. where running just cmake ../ (with flags for building utkscan and USE_HRIBF) then make does not build however if you use ccmake for the setup it will make without issue. We are currently investigating. Im going to leave this open so we can track the ideas for this.

ksmith0 commented 7 years ago

I will try to have a look at this tonight.

spaulaus commented 7 years ago

I'm closing this request since #256 has been closed as "won't fix". I will leave the branch so that the patch can be viewed if necessary.