Create local rule to validate isMounted usage in useAsyncEffect

pixiebrix / eslint-config-pixiebrix

Custom eslint config, to be used with Prettier

MIT License

1 stars 1 forks source link

Open grahamlangford opened 8 months ago

grahamlangford commented 8 months ago

We use https://www.npmjs.com/package/use-async-effect throughout the Extension
The callback function has an isMounted function arg
It is easy to forget to invoke isMounted when working with useAsyncEffect
We should create a local eslint rule to ensure we remember to invoke isMounted

fregante commented 7 months ago

This might also be possible via types. It was annoyance for me too:

Side note: components should prefer cancelling work in progress wherever possible (which is rarely possible, actually) https://legacy.reactjs.org/blog/2015/12/16/ismounted-antipattern.html