Incorrect font color on disabled buttons

[twschiller]

• The text color on disabled buttons is incorrect
• The bug was likely was introduced in one of the theming PRs

Let's add button swatch to StoryBook, with:

• Enabled
• Disable
• Each color variant

This screenshot is from the members table in the app:

@mnholtz could you add any context here? Links to code to look at?

[mnholtz]

I think this has something to do with my attempt to implement an equivalent to bootstraps color-yiq function, but css-variable compatible for my theming work. This function I wrote is located here: https://github.com/pixiebrix/pixiebrix-extension/blob/e6f5bdc4cfb97215aea25a25e087af5b781e182e/src/vendors/theme/assets/styles/_functions.scss#L11-L13

It might be that we just have to get rid of this function and just make all button text white for now. Implementing this function is challenging with css variables because it requires us defining our theme colors in rgba in addition to hsl.

@abdullah4244 for context, I originally wrote these functions as part of my work to start enabling theming ability in the extension. We wanted to use css variables for theming, which bootstrap doesn't support. So I had to start overriding the scss for common bootstrap components, like buttons, to be compatible with css variables.

[github-actions[bot]]

This issue will be closed in 7 days unless the stale label is removed, or a comment is added to the issue.

[github-actions[bot]]

This issue was closed because it has been stale for 7 days with no activity.