search

pixiebrix / pixiebrix-extension

PixieBrix browser extension
https://www.pixiebrix.com
GNU Affero General Public License v3.0
83 stars 22 forks source link

The hash should not be part of the match #427

Closed fregante closed 3 years ago

fregante commented 3 years ago

Not a bug per se, but I think it can cause confusion:

  1. Visit https://en.wikipedia.org/wiki/Information#Etymology
  2. Add a button in the dev tools
  3. Visit "Availability" tab
  4. See https://en.wikipedia.org/*#Etymology as a pattern
  5. Visit "Information theory" section on the page
  6. The pattern no longer matches and the button disappears (at some point)
Screen Shot 9
twschiller commented 3 years ago

See defaultMatchPattern here: https://github.com/pixiebrix/pixiebrix-extension/blob/ead1833564fff81288a195503b2dea57d3b55d2e/src/devTools/editor/extensionPoints/base.ts#L52

I'm not sure if match patterns even support hashes?