pixiebrix / pixiebrix-extension

PixieBrix browser extension
https://www.pixiebrix.com
GNU Affero General Public License v3.0
83 stars 22 forks source link

Consider supporting removal of X-Frame-Options header in iframe brick #436

Closed twschiller closed 10 months ago

twschiller commented 3 years ago

Some pages can't be embedded in the iframe brick because of the X-Frame-Options in their header.

We could support removing these out via the web request API to allow any page to be embedded: https://stackoverflow.com/a/15534822/402560

Considerations:

Security considerations:

fregante commented 3 years ago

Should we add the permission to optional_permissions instead?

twschiller commented 3 years ago

IIRC, in Manifest v2 it can't be marked as optional. In v3 declarativeNetRequest is mandatory:

https://developer.chrome.com/docs/extensions/reference/permissions/#step-2-declare-optional-permissions-in-the-manifest