search

pixiebrix / pixiebrix-extension

PixieBrix browser extension
https://www.pixiebrix.com
GNU Affero General Public License v3.0
82 stars 22 forks source link

Mods table action dropdown closes on its own on resource load #8458

Open fungairino opened 2 months ago

fungairino commented 2 months ago

Describe the bug

The dropdown for mod actions in the extension console closes by itself if you open it right after refreshing.

See: https://pixiebrix.slack.com/archives/C0436P48QHY/p1715633444678499

To Reproduce

See: https://www.loom.com/share/f638a468835044c095bcb598c6e3d7e5

Actual behavior

The dropdown if opened, will not close without user input.

Expected behavior

The dropdown if opened, will not close without user input.

Screenshots/Loom

See: https://www.loom.com/share/f638a468835044c095bcb598c6e3d7e5

Additional context

Related code pointers:

ListView https://github.com/pixiebrix/pixiebrix-extension/blob/78fe96dacffee27c9b9667eae10ebcd81c3ceab6/src/extensionConsole/pages/mods/listView/ListView.tsx#L30

ModsPageLayout https://github.com/pixiebrix/pixiebrix-extension/blob/563e7e48fc5766302aae715c9be8b04866366759/src/extensionConsole/pages/mods/ModsPageLayout.tsx#L130

twschiller commented 2 months ago

See Slack re-renders likely occur when marketplace query and/or registry items resolve

fungairino commented 3 weeks ago

Here is a end-to-end test report showing flaky tests due to this behavior: https://github.com/pixiebrix/pixiebrix-extension/actions/runs/9881381380/job/27292047996

fungairino commented 3 weeks ago

See: https://github.com/pixiebrix/pixiebrix-extension/blob/4deb84ec5045506e9dd7dbc7a371e8e5a2923e71/src/mods/useModViewItems.tsx#L178-L180

twschiller commented 3 weeks ago

Will likely want to solve root cause as part of vs. a band-aide solution https://www.notion.so/pixiebrix/Extension-Console-Mod-Screen-shift-left-conversion-to-common-mod-shape-d457621fc83d495bbeb135cbd3977ee6?pvs=4