pixiebrix / pixiebrix-extension

PixieBrix browser extension
https://www.pixiebrix.com
GNU Affero General Public License v3.0
83 stars 22 forks source link

Invariant check - Eliminate excess starter bricks #8592

Open fungairino opened 2 months ago

fungairino commented 2 months ago

We need to be sure to test that the invariant checks are working correctly. That includes deleting excess starterBrick definitions. (See this PR for additional context: https://github.com/pixiebrix/pixiebrix-extension/pull/8557).

twschiller commented 1 month ago

I recommend we don't spend time implementing a Playwright test on this. Time better spent fixing the root cause

fungairino commented 1 month ago

@grahamlangford can you provide a mod with duplicate extension points for this test?

grahamlangford commented 1 month ago

I recommend we don't spend time implementing a Playwright test on this. Time better spent fixing the root cause

I agree on fixing the root cause, but the implementation for this is straightforward and can be used to confirm that the fix for the root cause is also working as expected (we remove the deletions from the invariant check and the test should still pass without any changes)