Browser crashes when opening workshop if the Page Editor is open in a tab - Githubissues

pixiebrix / pixiebrix-extension

PixieBrix browser extension

https://www.pixiebrix.com

GNU Affero General Public License v3.0

83 stars 22 forks source link

Browser crashes when opening workshop if the Page Editor is open in a tab #8930

Closed twschiller closed 1 month ago

twschiller commented 1 month ago

Describe the bug

Browser crashes when opening workshop if the Page Editor is open in a tab
See bug Slack channel: https://pixiebrix.slack.com/archives/C07E7T1UFU3

To Reproduce

Steps to reproduce the behavior:

Open the page editor in a tab (docked)
Open the Extension Console in a new tab
Click “Open in Workshop” on a mod

Actual behavior

Browser crashes

Desktop (please complete the following information):

Browser: Chrome Version 127.0.6533.73 (Official Build) (arm64)
Extension Version: main (local build)
- Crash is also present in: v2.0.6-beta.1 in CWS, and 2.0.6-beta.2 production build

Investigation/Discussion

Doesn't happen if you do it in the other direction. I.e., you have the Workshop open and then open the page editor in a tab
Crash still happens if you open the Workshop via the Workshop side nav link and select a mod
Potentially related PRs:
- https://github.com/pixiebrix/pixiebrix-extension/pull/8831

Workaround

Undock the Dev Tools
Undock and redock the Dev Tools

Related Code

https://github.com/pixiebrix/pixiebrix-extension/blob/ef44074afc4b92c4ad7c6e05b97adb9344c67fec/src/extensionConsole/pages/packageEditor/EditPage.tsx#L203-L203

twschiller commented 1 month ago

Minimal reproduction here: https://github.com/pixiebrix/context-crash

getContexts called here: https://github.com/pixiebrix/pixiebrix-extension/blob/ef44074afc4b92c4ad7c6e05b97adb9344c67fec/src/tinyPages/offscreen.ts#L52-L52

twschiller commented 1 month ago

@BLoe I believe this can be closed out now?

twschiller commented 1 month ago

Mitigation in: https://github.com/pixiebrix/pixiebrix-extension/pull/8934