pixiebrix / pixiebrix-extension

PixieBrix browser extension
https://www.pixiebrix.com
GNU Affero General Public License v3.0
83 stars 22 forks source link

#9156: tab synchronized mod variable storage (3/3) #9181

Closed twschiller closed 1 week ago

twschiller commented 1 week ago

What does this PR do?

Remaining Work

Demo

Future Work

For more information on our expectations for the PR process, see the code review principles doc

github-actions[bot] commented 1 week ago

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 88.11881% with 12 lines in your changes missing coverage. Please review.

Project coverage is 74.81%. Comparing base (8318d74) to head (86d0070). Report is 312 commits behind head on main.

Files with missing lines Patch % Lines
...ipt/stateController/modVariablePolicyController.ts 80.00% 8 Missing :warning:
src/background/stateControllerListeners.ts 88.23% 2 Missing :warning:
src/background/background.ts 0.00% 1 Missing :warning:
src/store/deactivateUtils.ts 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9181 +/- ## ========================================== + Coverage 74.24% 74.81% +0.56% ========================================== Files 1332 1364 +32 Lines 40817 42036 +1219 Branches 7634 7850 +216 ========================================== + Hits 30306 31448 +1142 - Misses 10511 10588 +77 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 week ago

Playwright test results

passed  132 passed
flaky  2 flaky
skipped  4 skipped

Details

report  Open report ↗︎
stats  138 tests across 45 suites
duration  25 minutes, 57 seconds
commit  86d0070
info  For more information on how to debug and view this report, see our readme

Flaky tests chrome › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod msedge › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
Skipped tests chrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor msedge › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options