pixiebrix / pixiebrix-extension

PixieBrix browser extension
https://www.pixiebrix.com
GNU Affero General Public License v3.0
83 stars 22 forks source link

#9200 Remove save button from components - Slice 1 #9207

Closed BLoe closed 6 days ago

BLoe commented 1 week ago

What does this PR do?

For more information on our expectations for the PR process, see the code review principles doc

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 60.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 74.79%. Comparing base (8318d74) to head (f69102a). Report is 322 commits behind head on main.

Files with missing lines Patch % Lines
...itor/modListingPanel/DraftModComponentListItem.tsx 52.94% 8 Missing :warning:
src/pageEditor/modListingPanel/ModComponents.tsx 0.00% 3 Missing :warning:
src/bricks/exampleBrickConfigs.ts 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9207 +/- ## ========================================== + Coverage 74.24% 74.79% +0.54% ========================================== Files 1332 1366 +34 Lines 40817 42149 +1332 Branches 7634 7879 +245 ========================================== + Hits 30306 31526 +1220 - Misses 10511 10623 +112 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 week ago

Playwright test results

passed  130 passed
flaky  4 flaky
skipped  4 skipped

Details

report  Open report ↗︎
stats  138 tests across 45 suites
duration  13 minutes, 11 seconds
commit  f69102a
info  For more information on how to debug and view this report, see our readme

Flaky tests msedge › tests/modLifecycle.spec.ts › create, run, package, and update mod chrome › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod msedge › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod chrome › tests/pageEditor/copyMod.spec.ts › run a copied mod with a built-in integration
Skipped tests chrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor msedge › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
github-actions[bot] commented 6 days ago

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.