pixiebrix / pixiebrix-extension

PixieBrix browser extension
https://www.pixiebrix.com
GNU Affero General Public License v3.0
83 stars 22 forks source link

DX - Rename some tests so that the snapshots are useful for diffs in a future PR #9220

Closed BLoe closed 3 days ago

BLoe commented 3 days ago

What does this PR do?

For more information on our expectations for the PR process, see the code review principles doc

codecov[bot] commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.80%. Comparing base (8318d74) to head (2c59411). Report is 326 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9220 +/- ## ========================================== + Coverage 74.24% 74.80% +0.55% ========================================== Files 1332 1366 +34 Lines 40817 42149 +1332 Branches 7634 7879 +245 ========================================== + Hits 30306 31530 +1224 - Misses 10511 10619 +108 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 days ago

Playwright test results

passed  130 passed
flaky  4 flaky
skipped  4 skipped

Details

report  Open report ↗︎
stats  138 tests across 45 suites
duration  12 minutes, 22 seconds
commit  2c59411
info  For more information on how to debug and view this report, see our readme

Flaky tests chrome-setup › setup/affiliated.setup.ts › authenticate with affiliated user msedge-setup › setup/unaffiliated.setup.ts › authenticate with unaffiliated user chrome › tests/pageEditor/addNewMod.spec.ts › Add new mod, save, and then add starter bricks msedge › tests/pageEditor/addNewMod.spec.ts › Add new mod, save, and then add starter bricks
Skipped tests chrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor msedge › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
BLoe commented 3 days ago

I changed my mind, this isn't worth it, I'm just going to leave the playwright test named what it is