pixielabs / letsencrypt-rails-heroku

Automatic LetsEncrypt SSL certificates in your Rails app on Heroku.
MIT License
220 stars 33 forks source link

Persist account keys #50

Closed jalada closed 5 years ago

jalada commented 7 years ago

As discussed in https://github.com/pixielabs/letsencrypt-rails-heroku/issues/47, and in the README, we should really persist account keys in between renewals instead of re-registering with LetsEncrypt every time.

There may be an undocumented account limit per email address, which we might run in to. We've asked: https://community.letsencrypt.org/t/maximum-accounts-per-email-address/29908

jalada commented 7 years ago

Response indicates no limit, but obviously it'd still be nice to do this.

davidlibrera commented 7 years ago

@jalada the registration step is an association between a private_key and an email address. Imho generating a new account private_key and registering that key is a security improvement, so I suggest to continue with this. It has no cost registering a new private key so, why not?

jalada commented 5 years ago

Closed by #62