search

pixielabs / letsencrypt-rails-heroku

Automatic LetsEncrypt SSL certificates in your Rails app on Heroku.
MIT License
220 stars 33 forks source link

Raise an error when the HTTP challenge is nil #71

Closed mashedkeyboard closed 3 years ago

mashedkeyboard commented 3 years ago

Spotted this issue way back when the original ACME v2 implementation was being done, but it's pretty minor, so it doesn't look like it got picked up.

For now, this just raises an error; in future, this should use a DNS challenge if that's available, though. I did a lot of work on that in #60, which I might try and work some more on now - CloudFlare's new API tokens are here, so we can get it set up with that at least as supported DNS, and I'll build in providers as being modular so others can contribute others as and when needed.

Either way, for now, this PR addresses #69 - although perhaps not in a hugely satisfactory way, beyond just "not throwing some random file access stack trace".

jalada commented 3 years ago

@mashedkeyboard I'm so sorry, I somehow never saw this come in. I've put it on my list to check & merge in as soon as I can.

Thx for your patience!