search

pixijs / filters

Collection of community-authored custom display filters for PixiJS
https://pixijs.io/filters/docs/
MIT License
967 stars 158 forks source link

fixing PixiJS Deprecation Warnings #389

Closed FloodGames closed 8 months ago

FloodGames commented 1 year ago

I'm beginner. Look last 2 commits.

FloodGames commented 1 year ago

Thanks.

I'm on my way, it isn't finished, feel free to continue on this one. I'm signing off for today.

git clone https://github.com/FloodGames/filters.git

image

Note, sometimes Color is already a type!

FloodGames commented 1 year ago

Please check the code before approving!

image

The if/else seem a bit unnecessary?

FloodGames commented 1 year ago

Also fix this please: image

bigtimebuddy commented 8 months ago

Thank you for creating this PR and contributing, but unfortunately this PR has gotten a little stale. I'm going to close it, but if you want to continue to work on it, I would suggest that we break this down into smaller pull-requests to make it a little more manageable.