pixijs / filters

Collection of community-authored custom display filters for PixiJS
https://pixijs.io/filters/docs/
MIT License
968 stars 158 forks source link

Chore: Advanced Bloom Filter Deprecations #413

Closed bbazukun123 closed 9 months ago

bbazukun123 commented 9 months ago
bbazukun123 commented 9 months ago

I left some feedback but overall, I don't think we need this change. What is the harm in keeping number and number[] as a type for pixelSize and just convert it to a PointData in the pixelSize setter. Then you don't need all this extra work.

Thanks Matt, and apologies for the mess. I have addressed the feedback - essentially reverting the deprecation and allowing the number[]/[] as possible types for pixelSize param. Hope this looks neater now 🤞

I will align the other similar PRs shortly.