search

pixijs / floss

Unit-testing for those hard to reach places
https://www.npmjs.com/package/floss
MIT License
28 stars 8 forks source link

Supporting native ESM #38

Open ydaniv opened 3 years ago

ydaniv commented 3 years ago

Mocha as partial native support since 7.1.0, and seems to be full support since 8.0.0. Any chance of bumping mocha?

bigtimebuddy commented 3 years ago

Sure, I'm not sure why I haven't bumped it yet. But will give it a shot and see if I hit any issues.

ydaniv commented 3 years ago

@bigtimebuddy ping 🐼 any progress?

bigtimebuddy commented 3 years ago

I'm working on this, I hit a snag with v8.0.0. The Mocha reporting is broken and nothing shows up, trying to dig to see what's happening.

ydaniv commented 3 years ago

@bigtimebuddy looks like this is still not working since you're using require() to import the test files, and not import(), which is here, I believe: https://github.com/pixijs/floss/blob/main/src/renderer.ts#L110

bigtimebuddy commented 3 years ago

Okay, will look at it again.