emitter life issue fixed

pixijs / particle-emitter

A particle system for PixiJS

http://pixijs.io/particle-emitter/docs

MIT License

786 stars 124 forks source link

emitter life issue fixed #133

Closed serglider closed 4 years ago

serglider commented 4 years ago

Fixed issue: Despite the docs saying that the emitters will emit infinitely if emitterLifetimeprop is set to "-1", they will do so if emitterLifetimeprop is set to "0" as well.

This also handles the rare case that during emitting this._emitterLife can be calculated to be "0". In which case the emitting can unintentionally become infinite.

andrewstart commented 4 years ago

Hmm, after waking up fully, it appears my sleepy brain lied about there being a rare edge case here. Thanks for the fix!