search

pixijs / particle-emitter

A particle system for PixiJS
http://pixijs.io/particle-emitter/docs
MIT License
786 stars 124 forks source link

Class 'Container' defines instance member property 'renderCanvas', but extended class 'LinkedListContainer' defines it as in stance member function. #160

Closed konan21 closed 2 years ago

konan21 commented 2 years ago

Hello. I found one issue with typing Class 'Container' defines instance member property 'renderCanvas', but extended class 'LinkedListContainer' defines it as inst ance member function.

It happened in pixi-particles/index.d.ts:854:2 when I try to build the project. And it's related to interface DisplayObject and LinkedListContainer.renderCanvas()

Of cource I can use "skipLibCheck": true in tsconfig.json to not check all d.ts files, but I know about the error :)

image

image

Here is a repo to reproduce the error https://github.com/konan21/new_blank_pixijs_app

andrewstart commented 2 years ago

The current release doesn't support PixiJS 6 - you'll have to build the current master branch for that.

konan21 commented 2 years ago

Do you plan to make a release version to support PixiJS 6 soon?

andrewstart commented 2 years ago

Soon-ish. I want to get https://github.com/pixijs/pixi-particles/pull/158 in to concentrate all the breaking changes into one release. The runtime is complete, but I want to finish the data provided for editor usage.

andrewstart commented 2 years ago

Release 5.0.0 is now out.