search

pixijs / pixi-react

Write PIXI apps using React declarative style
https://pixijs.io/pixi-react/
MIT License
2.39k stars 180 forks source link

Uncaught Error: Could not find ID for Fiber "Canvas" #299

Closed AdrienLemaire closed 3 years ago

AdrienLemaire commented 3 years ago

Description

We've been noticing this warning for the past couple days, but cannot figure out what this is about, what problems it's creating and how to solve it.

Might you have any idea about it ?

Additional info

AdrienLemaire commented 3 years ago

@inlet got it. The issue started after upgrading the chrome plugin React Developer Tools. Can you look into this ? I guess it fails to understand how to read fibers generated by react-pixi

AdrienLemaire commented 3 years ago

Or maybe they already fixed it here ? https://github.com/facebook/react/commit/132b72d7b668cbdabb06a44bd62979b212fc8b6d#diff-0b1d99a530095ba9262958e2fc44878dedef4e175ed45ec3df3982e5b64538c1R12

inlet commented 3 years ago

Thanks! I'm experiencing the same thing 😞 The react-reconciler is not updated so that cannot be the issue..

I've updated my extensions but react-devtools is still on 4.13.3: image

Or maybe they already fixed it here ? facebook/react@132b72d#diff-0b1d99a530095ba9262958e2fc44878dedef4e175ed45ec3df3982e5b64538c1R12

Good catch! Yes that must be it, let's wait for the patch to be released

inlet commented 3 years ago

Just updated react devtools to 4.13.4 but no luck.

All examples on react-fiber-tree outputs the same Could not find ID for Fiber warning.

I guess we'll need to wait for a fix

BasixKOR commented 3 years ago

My components fail with warnings like below and I think this might be the cause of it, since I can see the Could not find ID for Fiber message too.


React instrumentation encountered an error: Error: Could not find ID for Fiber "Canvas"
inlet commented 3 years ago

Somehow the Could not find ID for Fiber error is gone. @AdrienLemaire can you verify it's working on your end?

AdrienLemaire commented 3 years ago

Looks fine. Now running react devtools 4.13.4 (5/20/2021)

AdrienLemaire commented 3 years ago

hmmm... I can see again warnings in my local env

Still using the same packages version as mentionned above, and React Developer Tools 4.13.4 (5/20/2021)

inlet commented 3 years ago

It's not related to react-pixi really, I get the same error when using react-dom in conjunction with <Suspense>. Seems like a bug in react devtools

inlet commented 3 years ago

@AdrienLemaire there's been another update, I've updated to 4.13.5 and now the warning is gone. Can you verify this?

AdrienLemaire commented 3 years ago

LGTM