search

pixijs / pixi-react

Write PIXI apps using React declarative style
https://pixijs.io/pixi-react/
MIT License
2.33k stars 177 forks source link

Implement portal #331

Closed zzmingo closed 2 years ago

zzmingo commented 2 years ago

I am going to implement the Portal feature for this cool library. Can we discuss whether my implementation method is reasonable?

inlet commented 2 years ago

Sounds interesting! Can you please elaborate on this? How would the API look like and how to use it?

Maybe use the same kind of interface as react-three-fiber? https://gracious-keller-98ef35.netlify.app/docs/recipes/re-parenting/

zzmingo commented 2 years ago

Ok, I'll find a fixed time to get this done. From react-three-fiber https://github.com/pmndrs/react-three-fiber/blob/764c0634e344feddbdf9beb48171c990da5a3f16/packages/fiber/src/web/index.tsx#L189 It doesn't do anything except wrap from createPortal of reconciler for typing.

inlet commented 2 years ago

Great! Then I’ll close this issue.. please let me know if we need to reopen it