Closed baseten closed 1 year ago
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit 3e08d61eb782c52e80354b3a4b88075f3a13a4b0:
Sandbox | Source |
---|---|
sandbox | Configuration |
Depends on: https://github.com/pixijs/pixi-react/pull/407 Easiest to review commit-by-commit
Converted modular codebase to Typescript 😅
There are still some improvements to be made:
DisplayObject
props and extend current component props from thoseForwardRefExoticComponent
forStage
lose the mount callback application type?Container
vsExpandoContainer
- sometimes we can probably just useContainer
BaseStage
andStageType
in componentscomponents/types.ts
orreact-types
moduleeventHandlers
definition fromFederatedEventEmitterTypes
DisplayObjectSettableProperties
Expando
stuff break inheritance chain or not?appendChild
/removeChild
double events?instance
andparent
fordidMount
andwillUnmount
types