pixijs / pixi-react

Write PIXI apps using React declarative style
https://pixijs.io/pixi-react/
MIT License
2.36k stars 179 forks source link

Bug: Peer Dependency of pixi.js breaks any app <7.2 #467

Closed robodove closed 5 months ago

robodove commented 9 months ago

Current Behavior

Everything was working until pixi.js released v7.3.3 yesterday

Now our production build fails, local builds fail

Expected Behavior

Well existing packages shouldn't be affected!

Steps to Reproduce

So far haven't been able to pin it down, but we get the error of

Can't redeclare "SORTABLE_CHILDREN";

Environment

Possible Solution

Well, maybe pin the peer dep <= 7.3.3 ?

Additional Information

No response

Zyie commented 5 months ago

Hi, i can't reproduce this

If you can provide me with an example i will reopen and look into this!

robodove commented 5 months ago

In any case, why would it make sense to not pin exact versions of PixiJS peer dependency?

Zyie commented 5 months ago

this project should work for any pixi v6/7 version, so it shouldn't need to be pinned to a specific version, just a major version which >=6.0.0 should cover