search

pixijs / pixi-react

Write PIXI apps using React declarative style
https://pixijs.io/pixi-react/
MIT License
2.36k stars 179 forks source link

feat: [WIP] `@pixi/react` v8 #490

Closed trezy closed 3 months ago

trezy commented 4 months ago
Description of change

This is a complete rewrite of @pixi/react. It leverages reflection and type inference to provide a new React pragma, allowing usage of all Pixi.js components via JSX within React applications.

A nice side effect is that this new version should be backward-compatible.

This PR supersedes @Zyie's work on #483, since we're now rewriting the library from the ground up.

Fixes: #476

Pre-Merge Checklist
lunarraid commented 4 months ago

What's the reasoning behind a complete rewrite rather than bumping the signatures from the prior version?

sergioisidoro commented 4 months ago

I'm also curious to know the rational behind a full re-write. The current version already has an implementation of a react reconciler, which seems to work with react fiber, with what looks like a well though out reconciliation strategy and event priorities. Could we perhaps get some more insight behind the factors that you considered?

There is a lot of code that is being removed, and with it a lot of accumulated knowledge and "chesterton fences".

utenma commented 4 months ago

maybe?

It leverages reflection and type inference to provide a new React pragma

A nice side effect is that this new version should be backward-compatible.

lunarraid commented 4 months ago

Definitely not backwards-compatible.

YVeselovskyi commented 3 months ago

hello :) is there any info when v8 support will be added?

thanks!

trezy commented 3 months ago

I've closed this PR since I've moved development to the dev branch for now. I also created a new issue (#493) to track progress on the new version of the library. That issue also provides context around the decision to rewrite the library from scratch, as well as other changes being made.