search

pixijs / pixi-react

Write PIXI apps using React declarative style
https://pixijs.io/pixi-react/
MIT License
2.42k stars 180 forks source link

Typescript Type Improvements #522

Closed thejustinwalsh closed 3 months ago

thejustinwalsh commented 3 months ago
Description of change

Refactor and improve Typescript types

Fixes:

Pre-Merge Checklist
codesandbox-ci[bot] commented 3 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 26b969aa846814895d2ea8d8e82af064984f0a9a:

Sandbox Source
pixi.js-sandbox Configuration
thejustinwalsh commented 3 months ago

I think I broke the typescript type emitting when I attempted to fix the tests, My bad. Working on an update now.

thejustinwalsh commented 3 months ago

Pulling https://pkg.csb.dev/pixijs/pixi-react/commit/26b969aa/@pixi/react into my local sandbox is working swimmingly!

For whatever reason, the CodeSanbox still tells me it can not find the types for the module!? 🤷

I'm pretty confident this is finally ready, but I could use your thoughts on the code sandbox issue.