pixijs / spine

Pixi.js plugin that enables Spine support.
Other
570 stars 217 forks source link

Spine v3.8 json format breaking changes #300

Open YuryKuvetski opened 5 years ago

YuryKuvetski commented 5 years ago

As I understand in Spine v3.8 json format was changed, skins now is an Array. It breaks your logic in the readSkeletonData function, it expects that root.skins is an object with skin names as keys and attachments as values.

dhartiste commented 3 years ago

Thanks for all this work! I am setting up a new implementation of pixi-spine with pixi4 and Spine 3.8. It looks like that is an active project so wondering if it's possible for you to make an npm version of that. So I can do npm install pixi-spine@pixi4-spine3.8 or something similar.

ivanpopelyshev commented 3 years ago

I honestly dont know how to npm publish that without changing current latest version. I'm too lazy to view. Do you have a tutorial or something?

I updated pixi4-3.8 just today, with new build in dist folder.

Also if you use pixi-heaven with it - i just updated v4 branch there too

dhartiste commented 3 years ago

In the meantime I found that you did have v1.6.1 which is a fairly recent build in npm for the pixi4 / spine3.8. You could publish the one you just updated with https://docs.npmjs.com/cli/v7/commands/npm-publish The syntax that they mention is below. It looks like as long as you use a tag then it would not be set to the 'latest'

npm publish [<tarball>|<folder>] [--tag <tag>] [--access <public|restricted>] [--otp otpcode] [--dry-run]

Publishes '.' if no argument supplied Sets tag 'latest' if no --tag specified

ivanpopelyshev commented 3 years ago

Done, looks like it works:https://www.npmjs.com/package/pixi-spine?activeTab=versions

npm install pixi-spine@pixi4-spine3.8