search

pixijs / spine

Pixi.js plugin that enables Spine support.
Other
569 stars 217 forks source link

Boundingbox not influenced by Spine's Boundingbox Attachment #419

Open Friksel opened 3 years ago

Friksel commented 3 years ago

The size of the loaded pixi-spine object is calculated well when using Region attachments, but it seems to ignore Spine's Bounding Box attachments as these don't influence the total size calculation of the object.

Bounding Box attachments are very useful for lots of things, but also to define the total size as a placeholder and prevents us to use a huge image we don't want for that.

Could the calculation of the total size of the pixi-spine skeleton please be expanded to also take into account Bounding Box Attachments? That would be sweet!

ivanpopelyshev commented 3 years ago

BBs are waiting for their hero who makes PR.

Friksel commented 3 years ago

Thanks @ivanpopelyshev . Your reactions are faster than a falling meteorite!

jacobdab commented 1 year ago

@ivanpopelyshev Are Bounding Box gonna be added to pixi-spine soon? I would love to use them, but don't understand how to add them myself. If not any chance to be done soon or any hints where to start working on it?

I started working on it ,but started to getting error on lerna build:

@pixi-spine/base@4.0.3 build:types

rimraf compile && tsc -p tsconfig-api.json && api-extractor run && node ../../scripts/injectGlobalMixins

[!] SyntaxError: Unexpected identifier at Loader.moduleStrategy (internal/modules/esm/translators.js:145:18) at async link (internal/modules/esm/module_job.js:67:21)

npm ERR! Lifecycle script build:rollup failed with error: npm ERR! Error: command failed npm ERR! in workspace: @pixi-spine/base@4.0.3 npm ERR! at location: C:\Users\Asus\WebstormProjects\spine\packages\base ERROR: "build:rollup" exited with 1. npm ERR! Lifecycle script build failed with error: npm ERR! Error: command failed npm ERR! in workspace: @pixi-spine/base@4.0.3 npm ERR! at location: C:\Users\Asus\WebstormProjects\spine\packages\base

jacobdab commented 8 months ago

@ivanpopelyshev Did by any chance this functionality was added?