search

pixijs / tilemap

Rectangular tilemap implementation for PixiJS
https://pixijs.io/tilemap/docs/
MIT License
284 stars 55 forks source link

Not compatible with Pixi 7 #145

Closed spassvogel closed 6 months ago

spassvogel commented 1 year ago

when trying to install @pixi/tilemap with pixijs 7

npm ERR! Could not resolve dependency:
npm ERR! @pixi/tilemap@"*" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: @pixi/core@6.5.8
npm ERR! node_modules/@pixi/core
npm ERR!   peer @pixi/core@"^6.0.4" from @pixi/tilemap@3.2.2
npm ERR!   node_modules/@pixi/tilemap
npm ERR!     @pixi/tilemap@"*" from the root project
ivanpopelyshev commented 1 year ago

Yes, still working on moving all my plugins to v7.

spassvogel commented 1 year ago

Great! Let me know if there's something I can do to help

steel97 commented 1 year ago

when trying to install @pixi/tilemap with pixijs 7

npm ERR! Could not resolve dependency:
npm ERR! @pixi/tilemap@"*" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: @pixi/core@6.5.8
npm ERR! node_modules/@pixi/core
npm ERR!   peer @pixi/core@"^6.0.4" from @pixi/tilemap@3.2.2
npm ERR!   node_modules/@pixi/tilemap
npm ERR!     @pixi/tilemap@"*" from the root project

It's quite easy to get this plugin work with pixi v7. Just update dependencies and change Renderer.registerPlugin to extensions.add in index.ts and CanvasTileRenderer.ts, also change AbstractRenderer to IRenderer. Here is my fork: https://github.com/steel97/pixi-tilemap/tree/v7_dev Changes that I made:

Also made vue3 + pixi-tilemap example: Code: https://github.com/steel97/vue3-pixi-tilemap Github pages example: https://steel97.github.io/vue3-pixi-tilemap/

ivanpopelyshev commented 1 year ago

Yes, i forgot about this plugin. I have private v7 workin vesion with same thing.Thank you, your branch will defeinitely help me because its tested!

spassvogel commented 1 year ago

Looking forward :)

ivanpopelyshev commented 1 year ago

Yo, @steel97 can i just merge yours? People say it works good.

I'm totally spent in my current work.

steel97 commented 1 year ago

@ivanpopelyshev Sure. However, I had to remove lastest pixi github workflow as it rely on outdated workflow: https://github.com/pixijs/tilemap/blob/daf420ee1aafcc59d4dd2f1da3366dbca54ecc01/.github/workflows/pixijs.yml#L43 Also I reverted rollup and it's plugins from latest version to currently used, mostly because of this outdated plugin https://github.com/pixijs/tilemap/blob/daf420ee1aafcc59d4dd2f1da3366dbca54ecc01/package.json#L64 I made pull request, should work fine with pixi v7. In future it would be cool to remove peerDependencies, switch build tools to vite and remove all outdated plugins, for reference here is awesome work that @cuire made for pixi-viewport (https://github.com/davidfig/pixi-viewport/pull/428)

jamespohalloran commented 8 months ago

Can this ticket be closed? I'm getting some mixed messages on if Pixi 7 is supported, so looking for some clarification:

Readme says:

It's designed to work with PixiJS 7.

The Pixi Migration doc on the other hand says its not compatible with v7: https://pixijs.com/guides/migrations/v7?_highlight=tilemap#%EF%B8%8F-plugin-supported

Thanks!

steel97 commented 8 months ago

Can this ticket be closed? I'm getting some mixed messages on if Pixi 7 is supported, so looking for some clarification:

Readme says:

It's designed to work with PixiJS 7.

The Pixi Migration doc on the other hand says its not compatible with v7: https://pixijs.com/guides/migrations/v7?_highlight=tilemap#%EF%B8%8F-plugin-supported

Thanks!

PIXI v7 supported since this PR: https://github.com/pixijs/tilemap/pull/148