search

pixincreate / PixeneOS

GrapheneOS with additionals
https://pixincreate.github.io/PixeneOS/
MIT License
7 stars 2 forks source link

Seems to default to checking bluejay despite different device defined #15

Closed 0cwa closed 3 months ago

0cwa commented 3 months ago

In github actions, under Check if a bulid already exists...

Run url="https://releases.grapheneos.org/bluejay-stable"
Tag with GrapheneOS version 2024082200 already exists. Looking for assets...
Missing assets:
  - bluejay-2024082200-magisk-*.zip
  - bluejay-2024082200-magisk-*.zip.csig
  - bluejay-2024082200-rootless-*.zip
  - bluejay-2024082200-rootless-*.zip.csig
Proceeding with build to create missing assets...
pixincreate commented 3 months ago

Even if the user passes the device name from input during workflow_dispatch, checks look for bluejay. However, if you look at patch step, I believe that should be created for the device mentioned during input, right?

It would be helpful if you could post complete logs for complete context as it contains no sensitive information.

Good catch BTW.

pixincreate commented 3 months ago

I've made some significant changes. Not sure whether it's good practice or not. But the intention is that, main code should not modified to make it work for you or anyone else.

User should just update an env.toml file and during run time, it is read and values from it takes precedence over default values.

pixincreate commented 3 months ago

Should be fixed with https://github.com/pixincreate/PixeneOS/commit/dfd9a75c22950e58f65a0bdcc3b30f287bf12dcb.

Please re-open if the issue persists.