pixiv / charcoal

Design system library by pixiv
https://charcoal-web.pixiv.design/
Apache License 2.0
313 stars 36 forks source link

fix: pixiv-icon waitUntilVisible condition #557

Closed yue4u closed 2 months ago

yue4u commented 2 months ago

やったこと

動作確認環境

チェックリスト

不要なチェック項目は消して構いません

mimokmt commented 2 months ago

@yue4u Thank you for the PR! We apologize for the inconvenience, but could you please add a Checkbox to the BottomSheet story of this Storybook to check the operation? packages/react/src/components/Modal/index.story.tsx

yue4u commented 2 months ago

@yue4u Thank you for the PR! We apologize for the inconvenience, but could you please add a Checkbox to the BottomSheet story of this Storybook to check the operation? packages/react/src/components/Modal/index.story.tsx

Is https://github.com/pixiv/charcoal/pull/557/commits/d306866edb14b1746ae6e8754b505d55d32a6296 the change you want? It's tricky to reproduce this issue and I don't see it happening on storybook.

mimokmt commented 2 months ago

@yue4u Thank you for the PR! We apologize for the inconvenience, but could you please add a Checkbox to the BottomSheet story of this Storybook to check the operation? packages/react/src/components/Modal/index.story.tsx

Is d306866 the change you want? It's tricky to reproduce this issue and I don't see it happening on storybook.

thank you! Sometimes I can confirm a problem with the image snapshot test, so I'm glad to have it.